Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tools: add avoid-prototype-pollution lint rule #43308

Merged
merged 3 commits into from
Jun 11, 2022
Merged

tools: add avoid-prototype-pollution lint rule #43308

merged 3 commits into from
Jun 11, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 3, 2022

To ensure the work in #43270 doesn't get reverted.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 3, 2022
@ljharb
Copy link
Member

ljharb commented Jun 3, 2022

LGTM!

Trott
Trott reviewed Jun 4, 2022
View reviewed changes
lib/.eslintrc.yaml Outdated
@@ -163,6 +163,7 @@ rules:
node-core/lowercase-name-for-primitive: error
node-core/non-ascii-character: error
node-core/no-array-destructuring: error
node-core/avoid-prototype-pollution: error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nit: The other rules are all in alphabetical order, so maybe consider moving this and/or renaming it? (no-pollutable-prototypes or something like that?)

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 10, 2022

@nodejs/linting can this get some reviews please?

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44428/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44433/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44434/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44435/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44439/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44440/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit 93728c6 into nodejs:master Jun 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 93728c6

@aduh95 aduh95 deleted the avoid-prototype-pollution-lint branch June 11, 2022 13:51
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@aduh95 @danielleadams
tools: add avoid-prototype-pollution lint rule
3d4063f 
PR-URL: #43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
italojs pushed a commit to italojs/node that referenced this pull request Jun 12, 2022
@aduh95 @italojs
tools: add avoid-prototype-pollution lint rule
9ccf8b9 
PR-URL: nodejs#43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@aduh95 @danielleadams
tools: add avoid-prototype-pollution lint rule
3891051 
PR-URL: #43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
15 tasks
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@aduh95 @danielleadams
tools: add avoid-prototype-pollution lint rule
cf8a115 
PR-URL: #43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
@targos
Copy link
Member

targos commented Jul 31, 2022

@aduh95 would you like to backport to v16.x?
The commit lands cleanly but introduces errors with the new rule on some files.
#43393 and #43391 could also be backported with it.

@targos
Copy link
Member

targos commented Jul 31, 2022

Also blocks #43475

aduh95 added a commit to aduh95/node that referenced this pull request Aug 1, 2022
@aduh95
tools: add avoid-prototype-pollution lint rule
ba9408b 
PR-URL: nodejs#43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 mentioned this pull request Aug 1, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Aug 1, 2022
@aduh95
tools: add avoid-prototype-pollution lint rule
0f489bc 
PR-URL: nodejs#43308
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2022
@aduh95 @targos
tools: add avoid-prototype-pollution lint rule
1d09407 
PR-URL: #43308
Backport-PR-URL: #44081
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
tools: add avoid-prototype-pollution lint rule
e404223 
PR-URL: nodejs/node#43308
Backport-PR-URL: nodejs/node#44081
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @ljharb @nodejs-github-bot @targos @Trott