events: improve Event compatibility
#43461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Jun 17, 2022
aduh95
approved these changes
Jun 17, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
LiviaMedeiros
approved these changes
Jun 17, 2022
lpinca
approved these changes
Jun 17, 2022
34 tasks
|
It looks better for consistency. Applied the suggestion. Thanks! Actually, it was named by following |
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
49682ce to
a4b26cb
Compare
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
a4b26cb to
b9a0f37
Compare
|
I squashed the fixup commits and added a commit to rename the files mentioned above. @lpinca PTAL, and, if it's reasonable, could you remove the |
|
@daeyeon can you please move |
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
b9a0f37 to
2d372b3
Compare
lpinca
approved these changes
Jun 18, 2022
|
@lpinca Thanks for the review, updated! |
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Jun 19, 2022
jasnell
approved these changes
Jun 27, 2022
github-actions
bot
removed
the
request-ci
23 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3f7f62f |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43467 Refs: nodejs/node#43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
Eventconstructor to improveEvent Web APIcompatibility.The test added was written by referring to wpt@dom/events/Event-constructors.any.js
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com