Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

crypto: use ByteSource::Builder in To*Copy #43477

Merged
merged 1 commit into from
Jun 25, 2022
Merged

crypto: use ByteSource::Builder in To*Copy #43477

merged 1 commit into from
Jun 25, 2022

Conversation

tniessen
Copy link
Member

Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead.

Refs: #43202

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

# to view
@tniessen
crypto: use ByteSource::Builder in To*Copy
0e6123d 
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and
use the new ByteSource::Builder instead.

Refs: nodejs#43202
@tniessen tniessen force-pushed the crypto-use-bytesource-builder-in-arraybufferorviewcontents branch from d14d479 to 0e6123d Compare June 18, 2022 18:52
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@github-actions github-actions bot mentioned this pull request Jun 19, 2022
Open
30 tasks
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Open
36 tasks
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2022
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
This was referenced Jun 21, 2022
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

# to view
@tniessen
Copy link
Member Author

cc @nodejs/cpp-reviewers

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44797/

@github-actions github-actions bot mentioned this pull request Jun 23, 2022
Open
33 tasks
This was referenced Jun 24, 2022
Open
Open
@tniessen tniessen added review wanted PRs that need reviews. commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Jun 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 42ad967 into nodejs:main Jun 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 42ad967

This was referenced Jun 26, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
crypto: use ByteSource::Builder in To*Copy
a43928a 
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and
use the new ByteSource::Builder instead.

Refs: #43202

PR-URL: #43477
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @RaisinTen @targos