repl: remove unused function #4403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replStart() was defined but never used. The function has been removed.
|
LGTM |
|
LGTM (would like @chrisdickinson's sign off tho) |
|
Ah, IIRC that became unused due to @Fishrock123's changes to the internal REPL. Anything that would have broken due to its disuse / removal has already broken (and presumably, been fixed.) LGTM. |
|
Landed in 590bc73 |
|
I think @bnoordhuis probably fixes the original issue, assuming it was the module/repl loading one. |
This was referenced Oct 16, 2020
This was referenced Nov 18, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replStart() was defined but never used. The function has been removed.
R=@chrisdickinson (Presumably, the hack involved using the function at some point and not merely having the function exist...)