src: remove usages of GetBackingStore in startup #44078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all usages of GetBackingStore in startup. See the linked issue for an explanation. Refs: nodejs#32226 Refs: nodejs#43921
|
Review requested:
|
nodejs-github-bot
added
c++
RaisinTen
approved these changes
Aug 1, 2022
F3n67u
approved these changes
Aug 1, 2022
F3n67u
added
author ready
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Aug 1, 2022
addaleax
approved these changes
Aug 1, 2022
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
11 tasks
kvakil
added
the
author ready
15 tasks
kvakil
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 24c1869 |
17 tasks
16 tasks
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
This removes all usages of GetBackingStore in startup. See the linked issue for an explanation. Refs: #32226 Refs: #43921 PR-URL: #44078 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
This removes all usages of GetBackingStore in startup. See the linked issue for an explanation. Refs: #32226 Refs: #43921 PR-URL: #44078 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This removes all usages of GetBackingStore in startup. See the linked issue for an explanation. Refs: nodejs#32226 Refs: nodejs#43921 PR-URL: nodejs#44078 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of GetBackingStore in startup. See the linked
issue for an explanation.
Refs: #32226
Refs: #43921