Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: update Web Streams WPT #44234

Merged

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Aug 14, 2022

This updates the tests and the status file via running git node wpt streams.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 14, 2022
@daeyeon daeyeon force-pushed the main.wpt-streams-220812.Fri.537a branch 2 times, most recently from dc1a924 to 6f78a5b Compare August 14, 2022 14:38
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

@daeyeon daeyeon force-pushed the main.wpt-streams-220812.Fri.537a branch from 6f78a5b to 1012e97 Compare August 14, 2022 16:59
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2022
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This updates the tests and the status file via
running `git node wpt streams`.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
@daeyeon daeyeon force-pushed the main.wpt-streams-220812.Fri.537a branch from 1012e97 to 38d2558 Compare August 16, 2022 04:33
@daeyeon
Copy link
Member Author

daeyeon commented Aug 16, 2022

Rebased to resolve conflicts. (test/wpt/status/streams.json is updated in #44155.)

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2022
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6dde810 into nodejs:main Aug 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6dde810

ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
This updates the tests and the status file via
running `git node wpt streams`.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44234
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
This updates the tests and the status file via
running `git node wpt streams`.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: nodejs#44234
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants