src: use automatic memory mgmt in SecretKeyGen #44479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid manual memory management (i.e., calling MallocOpenSSL). This leaves less room for memory leaks and other bugs.
tniessen
added
the
c++
|
Review requested:
|
nodejs-github-bot
added
crypto
tniessen
added
review wanted
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
17 tasks
|
cc @nodejs/cpp-reviewers |
addaleax
approved these changes
Sep 5, 2022
tniessen
added
the
author ready
bnoordhuis
approved these changes
Sep 5, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1f54fc2 |
This was referenced Sep 6, 2022
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Avoid manual memory management (i.e., calling MallocOpenSSL). This leaves less room for memory leaks and other bugs. PR-URL: nodejs#44479 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
It didn't land cleanly on v18.x. This PR conflicts with a security change in the same method ( node/src/crypto/crypto_keygen.cc Line 83 in 0c2a572 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid manual memory management (i.e., calling
MallocOpenSSL). This leaves less room for memory leaks and other bugs.The import bit here is using
ByteSource::Builder(see #43202).