Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bootstrap: generate bootstrapper arguments in BuiltinLoader #44488

Merged
merged 1 commit into from
Sep 13, 2022
Merged

bootstrap: generate bootstrapper arguments in BuiltinLoader #44488

merged 1 commit into from
Sep 13, 2022

Conversation

joyeecheung
Copy link
Member

First commit comes from #44472

@joyeecheung joyeecheung marked this pull request as ready for review September 2, 2022 06:29
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 2, 2022
@joyeecheung joyeecheung mentioned this pull request Sep 2, 2022
Closed
legendecas
legendecas reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but the linter is complaining...

@joyeecheung
Copy link
Member Author

Rebased and fixed the linter error.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46440/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46441/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46446/

@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Open
15 tasks
@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Sep 7, 2022
This was referenced Sep 8, 2022
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46530/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46537/

@github-actions github-actions bot mentioned this pull request Sep 13, 2022
Open
30 tasks
@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7850802 into nodejs:main Sep 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7850802

@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Open
28 tasks
@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Open
29 tasks
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@joyeecheung @Fyko
bootstrap: generate bootstrapper arguments in BuiltinLoader
4cdbc97 
PR-URL: nodejs#44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Sep 16, 2022
Open
23 tasks
@RafaelGSS
Copy link
Member

Hi @joyeecheung. This commit didn't land cleanly on v18.x. Could you please backport?

@RafaelGSS RafaelGSS added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 26, 2022
@juanarbol
Copy link
Member

The builtins thing did not land well in the v16.x release line (#44135); marking this as backport-blocked for the v16.x branch.

@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
Merged
@joyeecheung joyeecheung mentioned this pull request Oct 14, 2022
Merged
@codebytere codebytere mentioned this pull request Oct 24, 2022
Closed
@legendecas legendecas mentioned this pull request May 23, 2023
Closed
targos pushed a commit that referenced this pull request Oct 29, 2023
@joyeecheung @targos
bootstrap: generate bootstrapper arguments in BuiltinLoader
c1bc811 
PR-URL: #44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
bootstrap: generate bootstrapper arguments in BuiltinLoader
4e51651 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
bootstrap: generate bootstrapper arguments in BuiltinLoader
2b0472f 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @RafaelGSS @juanarbol @legendecas