Skip to content

buffer: initialize TextDecoder once for performance #44787

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

buffer: initialize TextDecoder once for performance #44787

merged 1 commit into from
Oct 10, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 25, 2022

Instead of creating TextDecoder everytime blob.text() is called, we are now using a previously created decoder.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 25, 2022
@anonrig anonrig changed the title blob: initialize TextDecoder once for performance buffer: initialize TextDecoder once for performance Sep 25, 2022
@anonrig anonrig force-pushed the perf/blob branch 2 times, most recently from b37eaa1 to f31f223 Compare September 25, 2022 17:03
aduh95
aduh95 reviewed Sep 25, 2022
View reviewed changes
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46819/

@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Open
14 tasks
This was referenced Sep 28, 2022
Open
Open
@MoLow MoLow mentioned this pull request Sep 30, 2022
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47142/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 76229fc into nodejs:main Oct 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 76229fc

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@anonrig @danielleadams
buffer: initialize TextDecoder once on blob.text()
725be0e 
PR-URL: #44787
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @jasnell @lpinca @targos @aduh95 @trivikr