Skip to content

test_runner: add extra fields in AssertionError YAML #44952

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

test_runner: add extra fields in AssertionError YAML #44952

merged 1 commit into from
Oct 26, 2022

Conversation

bengl
Copy link
Member

@bengl bengl commented Oct 10, 2022

Many TAP reporters offer special-case handling of YAML objects containing expected, actual, and operator fields, as produced by AssertionError and similar userland Error classes.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 10, 2022
@bengl bengl force-pushed the bengl/expected-actual branch from 75c6a05 to 669a977 Compare October 10, 2022 19:40
@MoLow
Copy link
Member

MoLow commented Oct 14, 2022

FYI @manekinekko let's make sure this addition is compatible with #43525 after it lands

@manekinekko
Copy link
Contributor

Yep, should be easy to add these fields here

node/lib/internal/test_runner/tap_parser.js

Lines 808 to 824 in 3b08f3c

// ----------------YAMLLine----------------
// YAMLLine := " " (YAML)* "\n"
#YAMLLine() {
const yamlLiteral = this.#readNextLiterals();
const { 0: key, 1: value } = StringPrototypeSplit(yamlLiteral, ':');
switch (key) {
case 'duration_ms':
this.#lastTestPointDuration = Number(value);
break;
// TODO(@manekinekko): should we handle other diagnostics data?
}
ArrayPrototypePush(this.#yamlBlockBuffer, yamlLiteral);
}

@manekinekko
Copy link
Contributor

Added in 26a2476

@bengl
test_runner: add extra fields in AssertionError YAML
6f09e43 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.
@bengl bengl force-pushed the bengl/expected-actual branch from 669a977 to 6f09e43 Compare October 25, 2022 01:11
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47465/

@bengl bengl added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/44952
✔  Done loading data for nodejs/node/pull/44952
----------------------------------- PR info ------------------------------------
Title      test_runner: add extra fields in AssertionError YAML (#44952)
Author     Bryan English  (@bengl)
Branch     bengl:bengl/expected-actual -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits    1
 - test_runner: add extra fields in AssertionError YAML
Committers 1
 - Bryan English 
PR-URL: https://github.com/nodejs/node/pull/44952
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44952
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test_runner: add extra fields in AssertionError YAML
   ℹ  This PR was created on Mon, 10 Oct 2022 19:30:45 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44952#pullrequestreview-1136519381
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44952#pullrequestreview-1143346750
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-25T12:38:51Z: https://ci.nodejs.org/job/node-test-pull-request/47465/
- Querying data for job/node-test-pull-request/47465/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3325742811

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 26, 2022
@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot merged commit e260b37 into nodejs:main Oct 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e260b37

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@bengl @RafaelGSS
test_runner: add extra fields in AssertionError YAML
293ffc1 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: #44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@bengl @RafaelGSS
test_runner: add extra fields in AssertionError YAML
ff174b0 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: #44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@bengl @MoLow
test_runner: add extra fields in AssertionError YAML
0a5b8f0 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@bengl @MoLow
test_runner: add extra fields in AssertionError YAML
e050e6e 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow MoLow mentioned this pull request Nov 24, 2022
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@bengl @MoLow
test_runner: add extra fields in AssertionError YAML
7a39747 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bengl @danielleadams
test_runner: add extra fields in AssertionError YAML
5a59312 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: #44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bengl @danielleadams
test_runner: add extra fields in AssertionError YAML
f63af47 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: #44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bengl @danielleadams
test_runner: add extra fields in AssertionError YAML
64860dd 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: #44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@bengl @MoLow
test_runner: add extra fields in AssertionError YAML
5fb0ffe 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs/node#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@bengl @MoLow
feat: add extra fields in AssertionError YAML
eea0d49 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs/node#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@bengl @MoLow
feat: add extra fields in AssertionError YAML
82a53bf 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs/node#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@bengl @MoLow
feat: add extra fields in AssertionError YAML
46dce07 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs/node#44952
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bengl @MoLow @manekinekko @nodejs-github-bot @jasnell