Skip to content

deps: patch V8 to 10.7.193.16 #45023

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

deps: patch V8 to 10.7.193.16 #45023

merged 1 commit into from
Oct 18, 2022

Conversation

targos
Copy link
Member

@targos targos commented Oct 16, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 16, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 16, 2022 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47286/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4929/

Trott
Trott approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1364fd8 into nodejs:main Oct 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1364fd8

@targos targos deleted the v8-patch-16 branch October 18, 2022 12:35
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@targos @RafaelGSS
deps: patch V8 to 10.7.193.16
ad0871c 
Refs: v8/v8@10.7.193.13...10.7.193.16
PR-URL: #45023
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@targos @RafaelGSS
deps: patch V8 to 10.7.193.16
3bfba6d 
Refs: v8/v8@10.7.193.13...10.7.193.16
PR-URL: #45023
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @jasnell @Trott @anonrig @cjihrig @gengjiawen @VoltrexKeyva @aduh95