Skip to content

lib: add lint rule to protect against Object.prototype.then pollution #45061

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

lib: add lint rule to protect against Object.prototype.then pollution #45061

merged 1 commit into from
Oct 21, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 19, 2022

Suggested by @MoLow in #45044 (review).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 19, 2022
JakobJingleheimer
JakobJingleheimer approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah, thanks!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47346/

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47350/

@github-actions github-actions bot mentioned this pull request Oct 20, 2022
Open
10 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47364/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47370/

@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Open
11 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit eb32a84 into nodejs:main Oct 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in eb32a84

@aduh95 aduh95 deleted the lint-object-then branch October 21, 2022 04:05
This was referenced Oct 22, 2022
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
lib: add lint rule to protect against Object.prototype.then pollution
a1075a1 
PR-URL: #45061
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
lib: add lint rule to protect against Object.prototype.then pollution
c7b7f2b 
PR-URL: #45061
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb left review comments

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@JungMinu JungMinu JungMinu approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @ljharb @jasnell @anonrig @JakobJingleheimer @JungMinu @MoLow