Skip to content

meta: remove dont-land-on-v12 auto labeling #45233

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

meta: remove dont-land-on-v12 auto labeling #45233

merged 1 commit into from
Oct 30, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 29, 2022 •
edited
Loading

both node 12 and 14 are not lts anymore

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 29, 2022
@cjihrig
Copy link
Contributor

cjihrig commented Oct 29, 2022

Node 14 is not EOL yet. Don't we still need that label?

@MoLow
Copy link
Member Author

MoLow commented Oct 29, 2022

AFAIK commits are cherry-picked without manual backporting to LTS release lines only

@aduh95
Copy link
Contributor

aduh95 commented Oct 29, 2022

Node.js 14.x is LTS, not Active LTS but still LTS.

Don't we still need that label?

Probably. @nodejs/releasers wdyt?

RafaelGSS
RafaelGSS reviewed Oct 30, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the v14 labels.

@targos
Copy link
Member

targos commented Oct 30, 2022

Yes, please keep the v14 labels.

@MoLow MoLow force-pushed the remove-old-node-labels branch from 3f336e6 to 8c92612 Compare October 30, 2022 06:15
@MoLow
Copy link
Member Author

MoLow commented Oct 30, 2022

Done

@MoLow MoLow force-pushed the remove-old-node-labels branch from 8c92612 to 825c481 Compare October 30, 2022 06:15
@MoLow MoLow changed the title meta: remove dont-land-on-v12/14 auto labeling meta: remove dont-land-on-v12 auto labeling Oct 30, 2022
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 30, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 77c0448 into nodejs:main Oct 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 77c0448

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@MoLow @RafaelGSS
meta: remove dont-land-on-v12 auto labeling
1af5dce 
PR-URL: #45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@MoLow @RafaelGSS
meta: remove dont-land-on-v12 auto labeling
0d58bb9 
PR-URL: #45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
meta: remove dont-land-on-v12 auto labeling
aa3beab 
PR-URL: #45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
meta: remove dont-land-on-v12 auto labeling
760a81a 
PR-URL: #45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@MoLow @danielleadams
meta: remove dont-land-on-v12 auto labeling
ffd0593 
PR-URL: #45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MoLow MoLow deleted the remove-old-node-labels branch May 24, 2024 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.