Skip to content

lib: delete unused parameter calls of the cjs module loader findPath method #45371

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

lib: delete unused parameter calls of the cjs module loader findPath method #45371

merged 1 commit into from
Feb 17, 2023

Conversation

sinkhaha
Copy link
Contributor

@sinkhaha sinkhaha commented Nov 8, 2022 •
edited
Loading

Delete unused parameter calls of the cjs module loader findPath method

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 8, 2022
@GeoffreyBooth GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47791/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47798/

@github-actions github-actions bot mentioned this pull request Nov 9, 2022
Open
14 tasks
@cola119 cola119 added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 9, 2022
This was referenced Nov 10, 2022
Open
Open
Open
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47883/

This was referenced Nov 13, 2022
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Open
13 tasks
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47982/

@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Open
12 tasks
This was referenced Nov 19, 2022
Open
Open
Open
Open
@sinkhaha sinkhaha requested a review from Trott January 30, 2023 15:42
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49271/

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49288/

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit a2bbe5f into nodejs:main Feb 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a2bbe5f

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@sinkhaha @MylesBorins
lib: delete module findPath unused params
4222e58 
PR-URL: #45371
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@sinkhaha @MylesBorins
lib: delete module findPath unused params
a740908 
PR-URL: #45371
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@sinkhaha @danielleadams
lib: delete module findPath unused params
1395e36 
PR-URL: #45371
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@sinkhaha sinkhaha deleted the feature/module_findpath_unused_params branch May 23, 2023 02:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@lpinca lpinca lpinca approved these changes

@cola119 cola119 cola119 approved these changes

@tony-go tony-go tony-go approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sinkhaha @nodejs-github-bot @jasnell @GeoffreyBooth @Trott @lpinca @cola119 @tony-go