No call to SetIdle() when terminating

src/api/callback.cc

@@ -97,10 +97,11 @@ void InternalCallbackScope::Close() {
   if (closed_) return;
   closed_ = true;
 
+  if (!env_->can_call_into_js()) return;
+
   Isolate* isolate = env_->isolate();
   auto idle = OnScopeLeave([&]() { isolate->SetIdle(true); });
 
-  if (!env_->can_call_into_js()) return;
   auto perform_stopping_check = [&]() {
     if (env_->is_stopping()) {
       MarkAsFailed();

test/parallel/test-unhandled-exception-with-worker-inuse.js

@@ -0,0 +1,27 @@
+'use strict';
+require('../common');
+
+// Check that node will not call v8::Isolate::SetIdle() when exiting
+// due to an unhandled exception, otherwise the assertion(enabled in
+// debug build only) in the SetIdle() will fail.
+//
+// The root cause of this issue is that before PerIsolateMessageListener()
+// is invoked by v8, v8 preserves the vm state, which is JS. However,
+// SetIdle() requires the vm state is either EXTERNEL or IDLE when embedder
+// calling it.
+
+if (process.argv[2] === 'child') {
+  const { Worker } = require('worker_threads');
+  new Worker('', { eval: true });
+  throw new Error('xxx');
+} else {
+  const assert = require('assert');
+  const { spawnSync } = require('child_process');
+  const result = spawnSync(process.execPath, [__filename, 'child']);
+
+  const stderr = result.stderr.toString().trim();
+  // Expect error message to be preserved
+  assert.match(stderr, /xxx/);
+  // Expect no crash message
+  assert.doesNotMatch(stderr, /node::DumpBacktrace/);
+}