src: add fast path to TextEncoder.encodeInto #45701

anonrig · 2022-12-01T14:27:33Z

Original commit message:

[fastcall] Implement support for onebyte string arguments

Refs: v8/v8@bc831f8

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1259/

                                                                                 confidence improvement accuracy (*)    (**)   (***)
util/text-encoder.js op='encodeInto' type='v8-one-byte-string' n=10000 len=0                     1.99 %       ±4.94%  ±6.58%  ±8.57%
util/text-encoder.js op='encodeInto' type='v8-one-byte-string' n=10000 len=1024         ***     13.53 %       ±6.84%  ±9.10% ±11.86%
util/text-encoder.js op='encodeInto' type='v8-one-byte-string' n=10000 len=256                   5.36 %       ±6.97%  ±9.29% ±12.12%
util/text-encoder.js op='encodeInto' type='v8-one-byte-string' n=10000 len=32768        ***     15.07 %       ±7.99% ±10.63% ±13.84%
util/text-encoder.js op='encodeInto' type='v8-two-byte-string' n=10000 len=0                    -5.38 %       ±6.23%  ±8.31% ±10.85%
util/text-encoder.js op='encodeInto' type='v8-two-byte-string' n=10000 len=1024                  1.45 %       ±6.77%  ±9.01% ±11.74%
util/text-encoder.js op='encodeInto' type='v8-two-byte-string' n=10000 len=256                  -2.36 %       ±7.55% ±10.05% ±13.08%
util/text-encoder.js op='encodeInto' type='v8-two-byte-string' n=10000 len=32768                -0.49 %       ±2.34%  ±3.11%  ±4.06%
util/text-encoder.js op='encode' type='v8-one-byte-string' n=10000 len=0                         1.62 %       ±6.95%  ±9.25% ±12.07%
util/text-encoder.js op='encode' type='v8-one-byte-string' n=10000 len=1024                     -2.32 %       ±5.28%  ±7.03%  ±9.17%
util/text-encoder.js op='encode' type='v8-one-byte-string' n=10000 len=256                      -4.58 %       ±6.07%  ±8.08% ±10.54%
util/text-encoder.js op='encode' type='v8-one-byte-string' n=10000 len=32768                     4.25 %      ±11.64% ±15.49% ±20.16%
util/text-encoder.js op='encode' type='v8-two-byte-string' n=10000 len=0                        -6.16 %       ±6.84%  ±9.11% ±11.86%
util/text-encoder.js op='encode' type='v8-two-byte-string' n=10000 len=1024                     -6.52 %       ±7.40%  ±9.85% ±12.83%
util/text-encoder.js op='encode' type='v8-two-byte-string' n=10000 len=256                      -6.35 %       ±6.74%  ±8.97% ±11.68%
util/text-encoder.js op='encode' type='v8-two-byte-string' n=10000 len=32768                    -5.08 %       ±7.21%  ±9.60% ±12.50%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 16 comparisons, you can thus
expect the following amount of false-positive results:
  0.80 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.16 false positives, when considering a   1% risk acceptance (**, ***),
  0.02 false positives, when considering a 0.1% risk acceptance (***)

Original commit message: [fastcall] Implement support for onebyte string arguments This CL adds one byte string specialization support for fast API call arguments. It introduces a kOneByteString variant to CTypeInfo. We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark. Rendered results: https://divy-v8-patches.deno.dev/ Bug: chromium:1052746 Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#84552} Refs: v8/v8@bc831f8

nodejs-github-bot · 2022-12-01T14:27:38Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2022-12-01T14:48:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48264/

nodejs-github-bot · 2022-12-01T14:49:20Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5027/

nodejs-github-bot · 2022-12-01T14:49:35Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5027/

nodejs-github-bot · 2022-12-01T14:51:51Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5027/

targos

I would be more inclined to accept this if the new capabilities were used by a subsequent commit. Otherwise the change doesn't bring anything to Node.js.

anonrig · 2022-12-01T15:02:11Z

I would be more inclined to accept this if the new capabilities were used by a subsequent commit. Otherwise the change doesn't bring anything to Node.js.

@targos Should I include my changes depending on this to this particular pull request, and add commit-queue-rebase?

targos · 2022-12-01T15:03:27Z

That would be fine, yes.

ShogunPanda · 2022-12-01T21:49:49Z

These changes look fine to me. I'm approving, but I agree on what @targos said.

nodejs-github-bot · 2022-12-02T14:16:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48278/

resolved

src/node_encoding.cc

lib/internal/encoding.js

tniessen · 2022-12-04T01:34:53Z

node.gyp

@@ -498,6 +498,7 @@
        'src/node_contextify.cc',
        'src/node_credentials.cc',
        'src/node_dir.cc',
+        'src/node_encoding.cc',


Nit: we already have so many files dealing with encodings, does this really need to be a new one (instead of, e.g., staying in node_buffer or maybe string_bytes)? And if so, is this the encoding file?

I don’t have any specific thoughts on this. I’ll try to move the encode utf8 to the node_encoding once this is implementation improves the existing benchmark.

I'm still not sure why this is a new file when it only covers a tiny part of all encoding-related routines.

src/node_encoding.cc

nodejs-github-bot · 2022-12-06T20:39:06Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5040/

nodejs-github-bot · 2022-12-06T20:41:27Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5040/

anonrig · 2022-12-06T21:16:28Z

@tniessen Can you review this, since in your last review, you requested changes?

lib/internal/encoding.js

src/node_encoding.cc

Co-authored-by: Anna Henningsen <anna@addaleax.net>

anonrig · 2022-12-08T15:10:20Z

@targos If it's ok, I recommend creating a pull request for merging the v8 cherry-pick, and continue this performance experiment in this pull request. There are several new areas (wasm for example) that can leverage this cherry-pick.

tniessen · 2022-12-09T12:59:39Z

test/parallel/test-util-text-encoder.js

+// For loop is required to trigger the fast path for encodeInto
+// Since v8 fast path is only triggered when v8 optimization starts.


There is no guarantee that V8 would take the fast path.

Suggested change

// For loop is required to trigger the fast path for encodeInto

// Since v8 fast path is only triggered when v8 optimization starts.

// Using a loop increases the chances of triggering the fast path for encodeInto

// because V8 heuristically optimizes based on information gathered at runtime.

tniessen · 2022-12-09T13:00:25Z

node.gyp

@@ -498,6 +498,7 @@
        'src/node_contextify.cc',
        'src/node_credentials.cc',
        'src/node_dir.cc',
+        'src/node_encoding.cc',


I'm still not sure why this is a new file when it only covers a tiny part of all encoding-related routines.

aduh95 · 2022-12-10T17:03:47Z

There are git conflicts, no Jenkins CI run on the last commit, and two collaborators blocking the PR, removing author ready PRs that have at least one approval, no pending requests for changes, and a CI started. .

anonrig · 2022-12-10T23:28:37Z

Thanks, @aduh95. Since other pull requests are merged, I’ll update this pull request only focusing on encodeInto.

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Dec 1, 2022

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2022

targos previously requested changes Dec 1, 2022

View reviewed changes

ShogunPanda approved these changes Dec 1, 2022

View reviewed changes

github-actions bot mentioned this pull request Dec 2, 2022

CI Reliability 2022-12-02 nodejs/reliability#446

Open

10 tasks

anonrig changed the title ~~deps: V8: cherry-pick bc831f8ba33b~~ src: add fast path to TextEncoder Dec 2, 2022

This was referenced Dec 3, 2022

CI Reliability 2022-12-03 nodejs/reliability#447

Open

CI Reliability 2022-12-04 nodejs/reliability#448

Open

anonrig added the review wanted PRs that need reviews. label Dec 4, 2022

anonrig commented Dec 4, 2022

View reviewed changes

src/node_encoding.cc Outdated Show resolved Hide resolved

anonrig commented Dec 4, 2022

View reviewed changes

lib/internal/encoding.js Outdated Show resolved Hide resolved

devsnek self-requested a review December 4, 2022 01:25

anonrig requested a review from mscdex December 4, 2022 01:27

anonrig changed the title ~~src: add fast path to TextEncoder~~ [WIP] src: add fast path to TextEncoder Dec 4, 2022

anonrig force-pushed the v8/fast-call branch from af9270a to 5c34041 Compare December 4, 2022 01:40

tniessen requested changes Dec 4, 2022

View reviewed changes

anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2022

github-actions bot mentioned this pull request Dec 7, 2022

CI Reliability 2022-12-07 nodejs/reliability#450

Open

10 tasks

targos reviewed Dec 7, 2022

View reviewed changes

lib/internal/encoding.js Outdated Show resolved Hide resolved

addaleax requested changes Dec 7, 2022

View reviewed changes

lib/internal/encoding.js Outdated Show resolved Hide resolved

src/node_encoding.cc Outdated Show resolved Hide resolved

src/node_encoding.cc Outdated Show resolved Hide resolved

anonrig force-pushed the v8/fast-call branch from 3642049 to bd013be Compare December 7, 2022 18:13

anonrig and others added 2 commits December 7, 2022 13:29

src: add encoding_methods with fast api

7601758

Co-authored-by: Anna Henningsen <anna@addaleax.net>

src: move decodeUtf8 to node_encoding

815fbee

anonrig force-pushed the v8/fast-call branch from bd013be to 815fbee Compare December 7, 2022 18:29

anonrig requested review from jasnell, targos and addaleax December 7, 2022 18:30

github-actions bot mentioned this pull request Dec 8, 2022

CI Reliability 2022-12-08 nodejs/reliability#451

Open

8 tasks

anonrig mentioned this pull request Dec 8, 2022

benchmark: add variety of inputs to text-encoder #45787

Merged

anonrig mentioned this pull request Dec 8, 2022

deps: V8: cherry-pick bc831f8ba33b #45788

Merged

github-actions bot mentioned this pull request Dec 9, 2022

CI Reliability 2022-12-09 nodejs/reliability#452

Open

5 tasks

tniessen reviewed Dec 9, 2022

View reviewed changes

github-actions bot mentioned this pull request Dec 10, 2022

CI Reliability 2022-12-10 nodejs/reliability#453

Open

9 tasks

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2022

github-actions bot mentioned this pull request Dec 11, 2022

CI Reliability 2022-12-11 nodejs/reliability#454

Open

11 tasks

anonrig removed the review wanted PRs that need reviews. label Dec 14, 2022

anonrig mentioned this pull request Dec 21, 2022

deps: add simdutf dependency #45803

Closed

jimmywarting mentioned this pull request Jan 27, 2023

ignore buffer in browsers kriszyp/cbor-x#67

Merged

targos removed their request for review March 10, 2023 15:44

anonrig closed this Apr 4, 2023

		// For loop is required to trigger the fast path for encodeInto
		// Since v8 fast path is only triggered when v8 optimization starts.

Uh oh!

src: add fast path to TextEncoder.encodeInto #45701

src: add fast path to TextEncoder.encodeInto #45701

Uh oh!

Conversation

anonrig commented Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

anonrig commented Dec 1, 2022

Uh oh!

targos commented Dec 1, 2022

Uh oh!

ShogunPanda commented Dec 1, 2022

Uh oh!

nodejs-github-bot commented Dec 2, 2022

Uh oh!

Uh oh!

Uh oh!

tniessen Dec 4, 2022

Choose a reason for hiding this comment

Uh oh!

anonrig Dec 4, 2022

Choose a reason for hiding this comment

Uh oh!

tniessen Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 6, 2022

Uh oh!

nodejs-github-bot commented Dec 6, 2022

Uh oh!

anonrig commented Dec 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrig commented Dec 8, 2022

Uh oh!

tniessen Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

tniessen Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Dec 10, 2022

Uh oh!

anonrig commented Dec 10, 2022

Uh oh!

Uh oh!

anonrig commented Dec 1, 2022 •

edited

Loading