Skip to content

tools: enforce use of trailing commas in tools/ #45889

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2022
Merged

tools: enforce use of trailing commas in tools/ #45889

merged 1 commit into from
Dec 18, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 16, 2022

Follow-up of #45471 and #45468.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 16, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48535/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3ce4cef into nodejs:main Dec 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3ce4cef

@aduh95 aduh95 deleted the tools-trailing-commas branch December 18, 2022 16:46
targos pushed a commit that referenced this pull request Jan 1, 2023
@aduh95 @targos
tools: enforce use of trailing commas in tools/
070a5f7 
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @RafaelGSS
tools: enforce use of trailing commas in tools/
794611a 
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@aduh95 @juanarbol
tools: enforce use of trailing commas in tools/
5aaa8c3 
PR-URL: #45889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @addaleax @anonrig