Skip to content

test: add failing test for #45992 #46075

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2023
Merged

test: add failing test for #45992 #46075

merged 1 commit into from
Jan 22, 2023

Conversation

alecmev
Copy link
Contributor

@alecmev alecmev commented Jan 3, 2023 •
edited by aduh95
Loading

Refs: #45992

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 3, 2023
@alecmev alecmev mentioned this pull request Jan 3, 2023
Closed
@alecmev
Copy link
Contributor Author

alecmev commented Jan 4, 2023

Force-pushed to fix a linting issue.

@alecmev
Copy link
Contributor Author

alecmev commented Jan 21, 2023

@anonrig @aduh95 Can you trigger the workflows again, please?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49123/

@aduh95 aduh95 merged commit de6c0e6 into nodejs:main Jan 22, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jan 22, 2023

Landed in de6c0e6

@alecmev alecmev deleted the rl branch January 22, 2023 11:59
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@alecmev @ruyadorno
test: add failing test for readline with carriage return
940484b 
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@alecmev @juanarbol
test: add failing test for readline with carriage return
c8ca4e0 
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@alecmev @juanarbol
test: add failing test for readline with carriage return
837ddcb 
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alecmev @nodejs-github-bot @aduh95 @jasnell @anonrig