test: fix flaky test-runner-exit-code.js #46138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/
anonrig
approved these changes
Jan 8, 2023
Trott
approved these changes
Jan 9, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
cjihrig
added
commit-queue
lpinca
approved these changes
Jan 9, 2023
benjamingr
approved these changes
Jan 9, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 384e1b5 |
24 tasks
This was referenced Jan 12, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: nodejs#46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: #46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
|
Needs #45712 to land on v18.x |
|
backporting #45712 is blocked by #46005 so I will be working on a backport PR containing all test runner prs CC @juanarbol @cjihrig |
|
see #46360 |
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: #46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: nodejs/node#46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: nodejs/node#46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error:
This commit resolves that flakiness.
Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/