Skip to content

stream: fix pipeline calling end on destination more than once #46226

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2023
Merged

stream: fix pipeline calling end on destination more than once #46226

merged 3 commits into from
Jan 19, 2023

Conversation

debadree25
Copy link
Member

Fixes: #42866

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 16, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48997/

@debadree25 @lpinca
fixup! comment fix
518210f 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
mcollina
mcollina approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48998/

@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49001/

@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Open
18 tasks
@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Open
14 tasks
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46226
✔  Done loading data for nodejs/node/pull/46226
----------------------------------- PR info ------------------------------------
Title      stream: fix pipeline calling end on destination more than once (#46226)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:fix/pipeline-end-call-twice -> nodejs:main
Labels     needs-ci
Commits    3
 - stream: fix pipeline calling end on destination more than once
 - fixup! add comment
 - fixup! comment fix
Committers 2
 - Debadree Chatterjee 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46226
Fixes: https://github.com/nodejs/node/issues/42866
Reviewed-By: Luigi Pinca 
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46226
Fixes: https://github.com/nodejs/node/issues/42866
Reviewed-By: Luigi Pinca 
Reviewed-By: Robert Nagy 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 16 Jan 2023 19:19:02 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250640553
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250611272
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1250634696
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46226#pullrequestreview-1251782740
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/46226#pullrequestreview-1252925760
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-01-17T07:50:52Z: https://ci.nodejs.org/job/node-test-pull-request/49001/
- Querying data for job/node-test-pull-request/49001/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46226
From https://github.com/nodejs/node
 * branch                  refs/pull/46226/merge -> FETCH_HEAD
✔  Fetched commits as 65f8a2716e6e..518210fae032
--------------------------------------------------------------------------------
[main 33373ab8ab] stream: fix pipeline calling end on destination more than once
 Author: Debadree Chatterjee 
 Date: Tue Jan 17 00:46:48 2023 +0530
 2 files changed, 36 insertions(+), 1 deletion(-)
[main 9367bca9b6] fixup! add comment
 Author: Debadree Chatterjee 
 Date: Tue Jan 17 00:48:40 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 4d1e96a827] fixup! comment fix
 Author: Debadree Chatterjee 
 Date: Tue Jan 17 01:15:30 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes

⚠  Found Fixes: #42866, skipping..

--------------------------------- New Message ----------------------------------

stream: fix pipeline calling end on destination more than once


Fixes: #42866

PR-URL: #46226

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Minwoo Jung nodecorelab@gmail.com


[detached HEAD d1947942e6] stream: fix pipeline calling end on destination more than once

Author: Debadree Chatterjee debadree333@gmail.com

Date: Tue Jan 17 00:46:48 2023 +0530

2 files changed, 36 insertions(+), 1 deletion(-)

Rebasing (3/6)

Rebasing (4/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup! add comment


PR-URL: #46226

Fixes: #42866

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Minwoo Jung nodecorelab@gmail.com


[detached HEAD 1fcc3019c4] fixup! add comment

Author: Debadree Chatterjee debadree333@gmail.com

Date: Tue Jan 17 00:48:40 2023 +0530

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/6)

Rebasing (6/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup! comment fix


Co-authored-by: Luigi Pinca luigipinca@gmail.com

PR-URL: #46226

Fixes: #42866

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com

Reviewed-By: Minwoo Jung nodecorelab@gmail.com


[detached HEAD ec21c0eef7] fixup! comment fix

Author: Debadree Chatterjee debadree333@gmail.com

Date: Tue Jan 17 01:15:30 2023 +0530

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/3956833441

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9a50c6d into nodejs:main Jan 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9a50c6d

@github-actions github-actions bot mentioned this pull request Jan 20, 2023
Open
13 tasks
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@debadree25 @RafaelGSS
stream: fix pipeline calling end on destination more than once
1869559 
Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@debadree25 @juanarbol
stream: fix pipeline calling end on destination more than once
f217492 
Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@debadree25 @juanarbol
stream: fix pipeline calling end on destination more than once
a87963d 
Fixes: #42866
PR-URL: #46226
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Feb 9, 2023
Closed
Closed
@debadree25 debadree25 mentioned this pull request Feb 10, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

end is called twice when using pipeline
7 participants
@debadree25 @nodejs-github-bot @mcollina @jasnell @lpinca @ronag @JungMinu