Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test_runner: fix missing test diagnostics #46450

Merged
merged 1 commit into from
Feb 2, 2023
Merged

test_runner: fix missing test diagnostics #46450

merged 1 commit into from
Feb 2, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jan 31, 2023

Fixes: #45911

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 31, 2023
@MoLow
Copy link
Member Author

MoLow commented Jan 31, 2023

CC @nodejs/test_runner @manekinekko

cjihrig
cjihrig approved these changes Jan 31, 2023
View reviewed changes
@MoLow MoLow force-pushed the emit-test-diagnotsics branch from 391a2e1 to 0d76e4d Compare January 31, 2023 20:06
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49287/

manekinekko
manekinekko reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@manekinekko manekinekko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49290/

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2023
@MoLow MoLow force-pushed the emit-test-diagnotsics branch from 0d76e4d to f9b919d Compare February 2, 2023 10:50
@MoLow
Copy link
Member Author

MoLow commented Feb 2, 2023

I've had to rebase after #46441 has landed
can someone re-approve for the sake of commit-queue Add this label to land a pull request using GitHub Actions. working?
CC @nodejs/test_runner

1 similar comment
@MoLow

This comment was marked as outdated.

# to view
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2023
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49306/

@MoLow MoLow requested review from aduh95 and benjamingr February 2, 2023 13:31
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1118db7 into nodejs:main Feb 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1118db7

@MoLow MoLow deleted the emit-test-diagnotsics branch February 4, 2023 18:10
@github-actions github-actions bot mentioned this pull request Feb 5, 2023
Open
22 tasks
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
test_runner: fix missing test diagnostics
17f0e2d 
PR-URL: nodejs/node#46450
Fixes: nodejs/node#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
fix: fix missing test diagnostics
22ccbdf 
PR-URL: nodejs/node#46450
Fixes: nodejs/node#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
@MoLow
fix: fix missing test diagnostics
b5b3f0b 
PR-URL: nodejs/node#46450
Fixes: nodejs/node#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to MoLow/node that referenced this pull request Feb 18, 2023
@MoLow
test_runner: fix missing test diagnostics
e759516 
PR-URL: nodejs#46450
Fixes: nodejs#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@MoLow @MylesBorins
test_runner: fix missing test diagnostics
c526f9f 
PR-URL: #46450
Fixes: #45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
194ef53 
PR-URL: nodejs#46450
Fixes: nodejs#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
e8fdd04 
PR-URL: nodejs#46450
Fixes: nodejs#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow added the backport-open-v18.x Indicate that the PR has an open backport. label Feb 25, 2023
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
f4264f0 
PR-URL: nodejs#46450
Fixes: nodejs#45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@MoLow @juanarbol
test_runner: fix missing test diagnostics
b48ad99 
PR-URL: #46450
Backport-PR-URL: #46839
Fixes: #45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@MoLow @juanarbol
test_runner: fix missing test diagnostics
ba784e8 
PR-URL: #46450
Backport-PR-URL: #46839
Fixes: #45911
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@manekinekko manekinekko manekinekko left review comments

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tony-go tony-go tony-go approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v18.x Indicate that the PR has an open backport. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test diagnostics are ommited when running with --test
6 participants
@MoLow @nodejs-github-bot @manekinekko @cjihrig @aduh95 @tony-go