Skip to content

url: remove unused URL::toObject #46486

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2023
Merged

url: remove unused URL::toObject #46486

merged 1 commit into from
Feb 5, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 3, 2023

Removing it before #46410 lands.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 3, 2023
@anonrig anonrig force-pushed the fix-remove-unused-url-toobject branch from cbf27d0 to b669bac Compare February 3, 2023 15:24
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49336/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49346/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49349/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2023
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Feb 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49360/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49363/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49366/

@github-actions github-actions bot mentioned this pull request Feb 5, 2023
Open
22 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit bea3a43 into nodejs:main Feb 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in bea3a43

This was referenced Feb 6, 2023
Open
Open
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @MylesBorins
url: remove unused URL::toObject
9a604d6 
PR-URL: #46486
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@anonrig @danielleadams
url: remove unused URL::toObject
f57e7bc 
PR-URL: #46486
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@tniessen tniessen tniessen approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @jasnell @lpinca @ronag @tniessen @himself65