src: check return value of ftell() #46495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: nodejs#46463
|
Review requested:
|
nodejs-github-bot
added
c++
gireeshpunathil
approved these changes
Feb 4, 2023
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Fast-track has been requested by @addaleax. Please 👍 to approve. |
joyeecheung
approved these changes
Feb 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Feb 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Feb 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
Something is wrong with Windows CI but I have no idea what it is. |
This was referenced Feb 5, 2023
RaisinTen
approved these changes
Feb 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
I think it's a flaky one, opened an issue about it - #46517. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1e9ca45 |
18 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ftell()returns-1L, abort instead of passingstatic_cast<size_t>(-1)to the vector allocator andfread().Refs: #46463