Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

events: add trailing commas in source files #46759

Merged
merged 1 commit into from
Feb 24, 2023
Merged

events: add trailing commas in source files #46759

merged 1 commit into from
Feb 24, 2023
+18 −16

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 22, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Feb 22, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 22, 2023
@aduh95 aduh95 merged commit 54f452d into nodejs:main Feb 24, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 24, 2023

Landed in 54f452d

@aduh95 aduh95 deleted the dangle-events branch February 24, 2023 08:45
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
events: add trailing commas in source files
33ce360 
PR-URL: #46759
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
events: add trailing commas in source files
1a23eab 
PR-URL: #46759
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
events: add trailing commas in source files
b08687f 
PR-URL: #46759
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @jasnell @targos @deokjinkim @MoLow @nodejs-github-bot