Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: stop faking performance idlharness #46794

Merged
merged 1 commit into from
Feb 25, 2023
Merged

test: stop faking performance idlharness #46794

merged 1 commit into from
Feb 25, 2023

Conversation

panva
Copy link
Member

@panva panva commented Feb 23, 2023

This is faking global attribute getters just for the sake of passing WPTs.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 23, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49937/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49952/

@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49970/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit f359614 into nodejs:main Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f359614

@panva panva deleted the wpt-no-brand-checks branch February 25, 2023 15:52
This was referenced Feb 26, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
test: stop faking performance idlharness
3daf508 
PR-URL: #46794
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 2, 2023
@danielleadams
Copy link
Contributor

Pulling this into v18.x-staging broke the test suite, so this needs a backport.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panva @nodejs-github-bot @danielleadams @jasnell @targos @legendecas