Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test_runner: fix reconstruction of errors extracted from YAML #46872

Merged
merged 3 commits into from
Mar 1, 2023
Merged

test_runner: fix reconstruction of errors extracted from YAML #46872

merged 3 commits into from
Mar 1, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Feb 27, 2023

Fixes #46871

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Feb 27, 2023
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50088/

BridgeAR
BridgeAR reviewed Feb 28, 2023
View reviewed changes
lib/internal/test_runner/yaml_to_js.js Outdated

if (isTestFailure) {
if (!isAssertionError) delete cause.code;
error = new ERR_TEST_FAILURE(cause, parsedYaml.failureType);
error.stack = stack;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent from this PR: the cause already contains the same stack. We could maybe limit it to either or?

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50114/

@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Open
15 tasks
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50119/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50122/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit c7e6a0c into nodejs:main Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c7e6a0c

This was referenced Mar 2, 2023
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@MoLow @targos
test_runner: fix reconstruction of errors extracted from YAML
63cab16 
PR-URL: #46872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@MoLow @targos
test_runner: fix reconstruction of errors extracted from YAML
0923cbc 
PR-URL: #46872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@MoLow @danielleadams
test_runner: fix reconstruction of errors extracted from YAML
524eaf5 
PR-URL: #46872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@MoLow MoLow deleted the fix-error-reconstruction branch May 24, 2024 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@Linkgoron Linkgoron Linkgoron approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner: errors are truncated in spec reporter when running with --test
7 participants
@MoLow @nodejs-github-bot @Linkgoron @benjamingr @cjihrig @BridgeAR @aduh95