Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tls_wrap: clear errors on return #4709

Closed
wants to merge 1 commit into from
Closed

tls_wrap: clear errors on return #4709

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Jan 15, 2016

Adopt MarkPopErrorOnReturn from node_crypto.cc, and use it to
clear errors after SSL_read/SSL_write/SSL_shutdown functions.

See: #4485
PR-URL: #4515
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Supersedes: #4687

@indutny
tls_wrap: clear errors on return
5f58cff 
Adopt `MarkPopErrorOnReturn` from `node_crypto.cc`, and use it to
clear errors after `SSL_read`/`SSL_write`/`SSL_shutdown` functions.

See: nodejs#4485
PR-URL: nodejs#4515
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny indutny mentioned this pull request Jan 15, 2016
Closed
@mscdex mscdex added tls Issues and PRs related to the tls subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jan 15, 2016
@jasnell
Copy link
Member

jasnell commented Jan 15, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jan 15, 2016
@indutny @jasnell
tls_wrap: clear errors on return
cfb0945 
Adopt `MarkPopErrorOnReturn` from `node_crypto.cc`, and use it to
clear errors after `SSL_read`/`SSL_write`/`SSL_shutdown` functions.

See: #4485
PR-URL: #4515
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

v4.x-staging Commit Metadata:
PR-URL: #4709
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 15, 2016

Landed in v4.x-staging in cfb0945

@jasnell jasnell closed this Jan 15, 2016
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@indutny
tls_wrap: clear errors on return
4d37472 
Adopt `MarkPopErrorOnReturn` from `node_crypto.cc`, and use it to
clear errors after `SSL_read`/`SSL_write`/`SSL_shutdown` functions.

See: #4485
PR-URL: #4515
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

v4.x-staging Commit Metadata:
PR-URL: #4709
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indutny @jasnell @mscdex