Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used" #47101

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used" #47101

merged 1 commit into from
Mar 15, 2023

Conversation

targos
Copy link
Member

@targos targos commented Mar 15, 2023 •
edited
Loading

This reverts commit 986498b.

Fixes: #47096

TODO if this lands: reopen #42080

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 15, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 15, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Mar 15, 2023

Unfortunately there is no known simple reproduction so I cannot add a test.
Requesting fast-track to prepare a quick fix release.

@targos targos added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Mar 15, 2023
@targos targos mentioned this pull request Mar 15, 2023
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50384/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit d0153ae into nodejs:main Mar 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d0153ae

@targos targos deleted the revert-47096 branch March 15, 2023 14:38
@targos targos mentioned this pull request Mar 15, 2023
Closed
targos added a commit that referenced this pull request Mar 15, 2023
@targos
Revert "vm: fix leak in vm.compileFunction when importModuleDynamical…
f7c8aa4 
…ly is used"

This reverts commit 986498b.

Fixes: #47096
PR-URL: #47101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Mar 15, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@danielleadams danielleadams danielleadams approved these changes

@legendecas legendecas legendecas approved these changes

@debadree25 debadree25 debadree25 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v19.8.0] module_wrap.cc:599: Assertion (it) != (env->id_to_function_map.end())' failed.