test: verify tracePromise does not do runStores #47349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
added
test
github-actions
bot
removed
the
request-ci
|
Fast-track has been requested by @Qard. Please 👍 to approve. |
anonrig
approved these changes
Mar 31, 2023
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Mar 31, 2023
38 tasks
github-actions
bot
removed
the
request-ci
Trott
reviewed
Apr 1, 2023
test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js
Outdated
Show resolved
Hide resolved
Trott
approved these changes
Apr 1, 2023
…-run-stores.js Co-authored-by: Rich Trott <rtrott@gmail.com>
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
30 tasks
github-actions
bot
removed
the
request-ci
Qard
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47349 ✔ Done loading data for nodejs/node/pull/47349 ----------------------------------- PR info ------------------------------------ Title test: verify tracePromise does not do runStores (#47349) Author Stephen Belanger (@Qard) Branch Qard:improve-tracing-channel-run-stores-tests -> nodejs:main Labels test, fast-track, needs-ci, diagnostics_channel Commits 2 - test: verify tracePromise does not do runStores - Update test/parallel/test-diagnostics-channel-tracing-channel-promise… Committers 2 - Stephen Belanger - GitHub PR-URL: https://github.com/nodejs/node/pull/47349 Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47349 Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 31 Mar 2023 18:41:01 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367513775 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367567448 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367811162 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-02T06:02:27Z: https://ci.nodejs.org/job/node-test-pull-request/50807/ - Querying data for job/node-test-pull-request/50807/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47349 From https://github.com/nodejs/node * branch refs/pull/47349/merge -> FETCH_HEAD ✔ Fetched commits as 85705a47958c..e9a266754cac -------------------------------------------------------------------------------- [main 20fcf19366] test: verify tracePromise does not do runStores Author: Stephen Belanger Date: Fri Mar 31 11:39:10 2023 -0700 1 file changed, 11 insertions(+), 4 deletions(-) [main 6fb6ce54ab] Update test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js Author: Stephen Belanger Date: Fri Mar 31 22:44:09 2023 -0700 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4589696191 |
28 tasks
Qard
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in cf83cae |
29 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just improving the test for this slightly. Chose to do a follow-up PR so as to not tempt fate with CI so soon before release cut-off. Requesting fast-track for this.