-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
deps: update simdutf to 3.2.7 #47473
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
deps/simdutf/simdutf.h
Outdated
@@ -572,7 +574,7 @@ SIMDUTF_DISABLE_UNDESIRED_WARNINGS | |||
#define SIMDUTF_SIMDUTF_VERSION_H | |||
|
|||
/** The version of simdutf being used (major.minor.revision) */ | |||
#define SIMDUTF_VERSION "3.2.3" | |||
#define SIMDUTF_VERSION "3.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to match the PR/commit title (3.2.7)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lemire This seems to be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welp, it is how it is in the official repo 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. It should be fixed now.
Commit Queue failed- Loading data for nodejs/node/pull/47473 ✔ Done loading data for nodejs/node/pull/47473 ----------------------------------- PR info ------------------------------------ Title deps: update simdutf to 3.2.7 (#47473) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-simdutf -> nodejs:main Labels needs-ci, dependencies Commits 2 - deps: update simdutf to 3.2.7 - deps: update simdutf to 3.2.7 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/47473 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47473 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Apr 2023 00:11:22 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47473#pullrequestreview-1376821039 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47473#pullrequestreview-1376942709 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-09T18:21:22Z: https://ci.nodejs.org/job/node-test-pull-request/51095/ - Querying data for job/node-test-pull-request/51095/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47473 From https://github.com/nodejs/node * branch refs/pull/47473/merge -> FETCH_HEAD ✔ Fetched commits as 08e1564474b4..7660c33f1397 -------------------------------------------------------------------------------- [main 02469b654c] deps: update simdutf to 3.2.7 Date: Sat Apr 8 00:11:19 2023 +0000 2 files changed, 1029 insertions(+), 787 deletions(-) [main 75499c15f5] deps: update simdutf to 3.2.7 Date: Sun Apr 9 00:24:37 2023 +0000 2 files changed, 4 insertions(+), 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4659786927 |
Landed in fdee40e |
PR-URL: #47473 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #47473 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#47473 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This is an automated update of simdutf to 3.2.7.