Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

url: reduce revokeObjectURL cpp calls #47728

Merged
merged 1 commit into from
Apr 30, 2023
Merged

url: reduce revokeObjectURL cpp calls #47728

merged 1 commit into from
Apr 30, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 26, 2023

Resolving a pending TODO. This pull request mainly reduces the C++ calls in revokeObjectURL function while removing the try/catch block.

cc @nodejs/url

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 26, 2023
@anonrig anonrig force-pushed the perf-revoke-object-url branch from 0b485ec to e67eafd Compare April 26, 2023 14:44
lemire
lemire reviewed Apr 26, 2023
View reviewed changes
@anonrig anonrig force-pushed the perf-revoke-object-url branch from e67eafd to 3e6638b Compare April 26, 2023 15:34
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51483/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51486/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51494/

@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Open
35 tasks
This was referenced Apr 28, 2023
Open
Open
Open
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6827dbb into main Apr 30, 2023
@nodejs-github-bot nodejs-github-bot deleted the perf-revoke-object-url branch April 30, 2023 12:38
@nodejs-github-bot
Copy link
Collaborator

Landed in 6827dbb

debadree25 added a commit to debadree25/node that referenced this pull request Apr 30, 2023
@debadree25
src: add a fast call for URL.revokeObjectURL
bcebfe9 
Refs: nodejs#47728
debadree25 added a commit to debadree25/node that referenced this pull request Apr 30, 2023
@debadree25
src: add a fast call for URL.revokeObjectURL
869ff2a 
Refs: nodejs#47728
@debadree25 debadree25 mentioned this pull request Apr 30, 2023
Draft
This was referenced May 1, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @targos
url: reduce revokeObjectURL cpp calls
821b3cd 
PR-URL: #47728
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
@anonrig @targos
url: reduce revokeObjectURL cpp calls
e4b6b79 
PR-URL: #47728
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jun 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lemire lemire lemire left review comments

@jasnell jasnell jasnell approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @lemire @jasnell @debadree25 @danielleadams