Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: add valgrind suppression details #47760

Merged
merged 1 commit into from
May 4, 2023
Merged

doc: add valgrind suppression details #47760

merged 1 commit into from
May 4, 2023

Conversation

KevinEady
Copy link
Contributor

Adds details on how to generate and use Valgrind suppressions to the "Investigating memory leaks with Valgrind" documentation.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2023
@KevinEady KevinEady marked this pull request as draft April 28, 2023 09:30
@KevinEady KevinEady force-pushed the add-valgrind-suppression-info branch from 755386e to 2e457bd Compare April 28, 2023 09:30
@KevinEady KevinEady marked this pull request as ready for review April 28, 2023 10:14
@KevinEady KevinEady mentioned this pull request Apr 28, 2023
Closed
mhdawson
mhdawson approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS
Copy link
Member

cc: @nodejs/diagnostics

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2ad5ea6 into nodejs:main May 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 2ad5ea6

targos pushed a commit that referenced this pull request May 12, 2023
@KevinEady @targos
doc: add valgrind suppression details
1666a14 
PR-URL: #47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@KevinEady @danielleadams
doc: add valgrind suppression details
4d7a66e 
PR-URL: #47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@KevinEady @MoLow
doc: add valgrind suppression details
8bcfcc0 
PR-URL: nodejs#47760
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

@tony-go tony-go tony-go approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KevinEady @nodejs-github-bot @RafaelGSS @lpinca @legendecas @mhdawson @tony-go