Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: fix webcrypto wrap unwrap tests #47876

Merged
merged 1 commit into from
May 7, 2023
Merged

test: fix webcrypto wrap unwrap tests #47876

merged 1 commit into from
May 7, 2023

Conversation

panva
Copy link
Member

@panva panva commented May 5, 2023 •
edited
Loading

The wrap/unwrap promises are now properly handled.

Refs: #47864

cc @tniessen @fhanau

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels May 5, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 5, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51654/

@panva
Copy link
Member Author

panva commented May 5, 2023

Note: the tests did actually execute before, but would cause an unhandled rejection in the file if they failed instead of reporting properly.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51662/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51664/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
This was referenced May 6, 2023
Open
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit ecf1427 into nodejs:main May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ecf1427

@panva panva deleted the webcrypto-wrap-unwrap-tests branch May 7, 2023 11:31
This was referenced May 8, 2023
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
@panva @targos
test: fix webcrypto wrap unwrap tests
7e34f77 
Refs: #47864
PR-URL: #47876
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test: fix webcrypto wrap unwrap tests
43c967e 
Refs: #47864
PR-URL: #47876
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva @MoLow
test: fix webcrypto wrap unwrap tests
81d8d95 
Refs: nodejs#47864
PR-URL: nodejs#47876
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @lpinca @tniessen