Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: register ext reference for Fingerprint512 #47892

Merged
merged 1 commit into from
May 8, 2023
Merged

src: register ext reference for Fingerprint512 #47892

merged 1 commit into from
May 8, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 6, 2023

Refs: #39809
Refs: #40239

@tniessen tniessen requested a review from joyeecheung May 6, 2023 01:30
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 6, 2023
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2023
@nodejs-github-bot

This comment was marked as outdated.

# to view
@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51682/

@github-actions github-actions bot mentioned this pull request May 7, 2023
Open
27 tasks
@github-actions github-actions bot mentioned this pull request May 8, 2023
Open
26 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9398ff1 into nodejs:main May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9398ff1

This was referenced May 9, 2023
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
@tniessen @targos
src: register ext reference for Fingerprint512
9bc5d78 
Refs: #39809
Refs: #40239
PR-URL: #47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
src: register ext reference for Fingerprint512
e1929e1 
Refs: #39809
Refs: #40239
PR-URL: #47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen @MoLow
src: register ext reference for Fingerprint512
33daa89 
Refs: nodejs#39809
Refs: nodejs#40239
PR-URL: nodejs#47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @panva @lpinca @joyeecheung @BridgeAR