Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

crypto: remove default encoding from scrypt #47943

Merged
merged 1 commit into from
May 12, 2023
Merged

crypto: remove default encoding from scrypt #47943

merged 1 commit into from
May 12, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 9, 2023

Refs: #47182

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 9, 2023
@tniessen tniessen added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels May 9, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2023
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51750/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@github-actions github-actions bot mentioned this pull request May 11, 2023
Open
24 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2e67401 into nodejs:main May 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 2e67401

@github-actions github-actions bot mentioned this pull request May 12, 2023
Open
23 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@tniessen @targos
crypto: remove default encoding from scrypt
6f39211 
Refs: #47182
PR-URL: #47943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 13, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 15, 2023
@tniessen @targos
crypto: remove default encoding from scrypt
d799347 
Refs: #47182
PR-URL: #47943
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 16, 2023
Open
19 tasks
@github-actions github-actions bot mentioned this pull request May 17, 2023
Open
17 tasks
tniessen added a commit to tniessen/node that referenced this pull request Aug 14, 2023
@tniessen
crypto: remove getDefaultEncoding()
d66373c 
Refs: nodejs#47182
Refs: nodejs#47869
Refs: nodejs#47943
Refs: nodejs#47998
Refs: nodejs#49140
Refs: nodejs#49145
Refs: nodejs#49167
Refs: nodejs#49169
@tniessen tniessen mentioned this pull request Aug 14, 2023
Closed
tniessen added a commit to tniessen/node that referenced this pull request Aug 16, 2023
@tniessen
crypto: remove getDefaultEncoding()
d4a91a8 
Refs: nodejs#47182
Refs: nodejs#47869
Refs: nodejs#47943
Refs: nodejs#47998
Refs: nodejs#49140
Refs: nodejs#49145
Refs: nodejs#49167
Refs: nodejs#49169
debadree25 pushed a commit that referenced this pull request Aug 19, 2023
@tniessen @debadree25
crypto: remove getDefaultEncoding()
78842cf 
Refs: #47182
Refs: #47869
Refs: #47943
Refs: #47998
Refs: #49140
Refs: #49145
Refs: #49167
Refs: #49169
PR-URL: #49170
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@tniessen @UlisesGascon
crypto: remove getDefaultEncoding()
7eb10a3 
Refs: #47182
Refs: #47869
Refs: #47943
Refs: #47998
Refs: #49140
Refs: #49145
Refs: #49167
Refs: #49169
PR-URL: #49170
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @panva @jasnell @lpinca @anonrig