Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deps: update simdutf to 3.2.12 #48118

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented May 22, 2023

This is an automated update of simdutf to 3.2.12.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 22, 2023
@anonrig anonrig added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels May 22, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 3.2.10 deps: update simdutf to 3.2.11 May 22, 2023
@tniessen
Copy link
Member

It's unfortunate that the update workflow just keeps adding commits (see gr2m/create-or-update-pull-request-action#555). It might make sense to close existing PRs and to delete the respective branch before manually running the GitHub action.

@Trott Trott force-pushed the actions/tools-update-simdutf branch from 60d7046 to 7195d28 Compare May 22, 2023 22:52
@Trott
Copy link
Member

Trott commented May 22, 2023

It's unfortunate that the update workflow just keeps adding commits

I've squashed the two commits into a single commit.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot changed the title deps: update simdutf to 3.2.11 deps: update simdutf to 3.2.12 May 23, 2023
@anonrig
Copy link
Member

anonrig commented May 23, 2023

@targos Can you try the new version?

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be squashed again.

@Trott Trott force-pushed the actions/tools-update-simdutf branch from 93382cc to 4702879 Compare May 23, 2023 17:18
@Trott
Copy link
Member

Trott commented May 23, 2023

Should be squashed again.

Done.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit d39ba8a into main May 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in d39ba8a

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-simdutf branch May 23, 2023 21:49
targos pushed a commit that referenced this pull request May 30, 2023
PR-URL: #48118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants