Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

stream: remove asIndexedPairs #48150

Merged
merged 1 commit into from
Jun 13, 2023
Merged

stream: remove asIndexedPairs #48150

merged 1 commit into from
Jun 13, 2023

Conversation

atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented May 24, 2023 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 24, 2023
@atlowChemi
Copy link
Member Author

atlowChemi commented May 24, 2023 •
edited
Loading

@aduh95 @benjamingr as discussed in #48102 (review) this should have the dont-land-on-20.x label 🙂

@MoLow MoLow added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels May 24, 2023
aduh95
aduh95 approved these changes May 24, 2023
View reviewed changes
@benjamingr benjamingr added the blocked PRs that are blocked by other issues or PRs. label May 24, 2023
@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Jun 8, 2023
@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2023
@atlowChemi atlowChemi force-pushed the remove-asIndexedPairs branch from b2dae8d to 448c208 Compare June 13, 2023 07:28
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52234/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52236/

@aduh95 aduh95 added experimental Issues and PRs related to experimental features. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 13, 2023
@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit d4e99b1 into nodejs:main Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d4e99b1

@atlowChemi atlowChemi deleted the remove-asIndexedPairs branch June 13, 2023 12:55
This was referenced Jun 14, 2023
Open
Open
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Open
29 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: remove asIndexedPairs
f8ed71b 
PR-URL: nodejs#48150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: remove asIndexedPairs
24be3c4 
PR-URL: nodejs#48150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atlowChemi @nodejs-github-bot @benjamingr @aduh95 @MoLow