Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: fix error codes for test-dns-idna2008 #48270

Closed
wants to merge 2 commits into from
Closed

test: fix error codes for test-dns-idna2008 #48270

wants to merge 2 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 31, 2023

Fixes #48262

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 31, 2023
lpinca
lpinca approved these changes May 31, 2023
View reviewed changes
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2023
@anonrig anonrig requested a review from lpinca May 31, 2023 20:20
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52035/

targos
targos requested changes May 31, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A revert of 8b5cd32 fixes the issue. I'm pretty sure it's not a problem with the test or with the resolution of the host name.
My guess is that returns ENOTFOUND because the DNS query isn't done with the right name.

@anonrig
Copy link
Member Author

anonrig commented May 31, 2023

You're right @targos. This is most likely a bug in not calling ada::idna::to_ascii in cares_wrap.cc int ATraits::Parse function.

@anonrig anonrig closed this May 31, 2023
This was referenced Jun 2, 2023
Open
Open
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos requested changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/internet/test-dns-idna2008.js fails
4 participants
@anonrig @nodejs-github-bot @lpinca @targos