bootstrap: hide experimental web globals with flag kNoBrowserGlobals #48545
+43
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not install experimental web globals when the environment is initialized with embedder flag `node::EnvironmentFlags::kNoBrowserGlobals`.
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jun 25, 2023
21 tasks
This was referenced Jun 27, 2023
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in c47ea21 |
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
Do not install experimental web globals when the environment is initialized with embedder flag `node::EnvironmentFlags::kNoBrowserGlobals`. PR-URL: #48545 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Do not install experimental web globals when the environment is initialized with embedder flag `node::EnvironmentFlags::kNoBrowserGlobals`. PR-URL: nodejs#48545 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Do not install experimental web globals when the environment is initialized with embedder flag `node::EnvironmentFlags::kNoBrowserGlobals`. PR-URL: nodejs#48545 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v18.x
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not install experimental web globals when the environment is
initialized with embedder flag
node::EnvironmentFlags::kNoBrowserGlobals.