build: do not pass target toolchain flags to host toolchain #48597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64.
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
33 tasks
richardlau
approved these changes
Jun 30, 2023
richardlau
added
the
author ready
This was referenced Jul 1, 2023
19 tasks
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 78e42e4 |
juanarbol
pushed a commit
that referenced
this pull request
Jul 13, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: nodejs#48597 Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: nodejs#48597 Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 12, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <rlau@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64.
See also NixOS/nixpkgs#238377 (comment)