Skip to content

deps: upgrade to libuv 1.46.0 #48618

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2023
Merged

deps: upgrade to libuv 1.46.0 #48618

merged 1 commit into from
Jul 2, 2023

Conversation

santigimeno
Copy link
Member

@santigimeno santigimeno commented Jun 30, 2023 •
edited
Loading

@santigimeno
deps: upgrade to libuv 1.46.0
9a5fa6f 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
@santigimeno santigimeno self-assigned this Jun 30, 2023
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Jun 30, 2023
@santigimeno santigimeno added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52570/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52575/

@github-actions github-actions bot mentioned this pull request Jul 1, 2023
Open
30 tasks
@santigimeno santigimeno added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2023
@github-actions github-actions bot mentioned this pull request Jul 2, 2023
Open
27 tasks
@richardlau richardlau mentioned this pull request Jul 2, 2023
Closed
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit acf071e into nodejs:main Jul 2, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in acf071e

@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Open
24 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@santigimeno @RafaelGSS
deps: upgrade to libuv 1.46.0
6199e19 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Open
22 tasks
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jul 4, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Open
20 tasks
@Grmiade Grmiade mentioned this pull request Jul 7, 2023
Open
This was referenced Jul 8, 2023
Open
Open
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@santigimeno @Ceres6
deps: upgrade to libuv 1.46.0
a2f18db 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: nodejs#48618
Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@santigimeno @Ceres6
deps: upgrade to libuv 1.46.0
f44cbfc 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: nodejs#48618
Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
arsnyder16 pushed a commit to arsnyder16/node that referenced this pull request Sep 10, 2023
@santigimeno @arsnyder16
deps: upgrade to libuv 1.46.0
0c99404 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: nodejs#48618
Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@arsnyder16 arsnyder16 mentioned this pull request Sep 10, 2023
Closed
@ruyadorno
Copy link
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@richardlau
Copy link
Member

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

#49591

ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
8af0d8c 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
0ed29c0 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
88855e0 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #48078
@richardlau richardlau mentioned this pull request Oct 4, 2023
Closed
@legendecas legendecas mentioned this pull request Mar 13, 2024
Merged
4 tasks
@spljs spljs mentioned this pull request Apr 8, 2024
Closed
@nbsp nbsp mentioned this pull request Apr 12, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees

@santigimeno santigimeno

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@santigimeno @nodejs-github-bot @ruyadorno @richardlau @lpinca @anonrig @cjihrig @VoltrexKeyva