Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[v18.x]: fix py-lint #48753

Closed
wants to merge 2 commits into from
Closed

[v18.x]: fix py-lint #48753

wants to merge 2 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 13, 2023

this backports the changes from #48505
adjusting changes done in fcf3781 to work after it

Trott and others added 2 commits July 13, 2023 09:26
@Trott @MoLow
tools: pin ruff version number
438accd 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MoLow
build: revert unkonwn ruff selector
fc70e95
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jul 13, 2023
@MoLow MoLow mentioned this pull request Jul 13, 2023
Merged
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52747/

@MoLow MoLow changed the title [v18.x backport]: fix py-lint [v18.x]: fix py-lint Jul 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52748/

juanarbol
juanarbol approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@juanarbol juanarbol added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @juanarbol. Please 👍 to approve.

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 15, 2023
This was referenced Jul 16, 2023
Open
Open
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@Trott @danielleadams
tools: pin ruff version number
7786d7c 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Backport-PR-URL: #48753
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@MoLow @danielleadams
build: revert unkonwn ruff selector
d002f9b 
PR-URL: #48753
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@danielleadams
Copy link
Contributor

Landed in 6f3a8b4...d002f9b

@MoLow MoLow deleted the fix-py-lint branch July 17, 2023 06:27
This was referenced Jul 18, 2023
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MoLow @nodejs-github-bot @danielleadams @juanarbol @panva @Trott