url: fix canParse false value when v8 optimizes
#48817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
This was referenced Jul 17, 2023
anonrig
added
request-ci
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Jul 17, 2023
lemire
approved these changes
Jul 17, 2023
KhafraDev
approved these changes
Jul 17, 2023
tniessen
reviewed
Jul 17, 2023
| @@ -19,3 +19,11 @@ const { canParse } = internalBinding('url'); | |||
| // It should not throw when called without a base string | |||
| assert.strictEqual(URL.canParse('https://example.org'), true); | |||
| assert.strictEqual(canParse('https://example.org'), true); | |||
|
|
|||
| // This for-loop is used to test V8 Fast API optimizations | |||
There was a problem hiding this comment.
Suggested change
| // This for-loop is used to test V8 Fast API optimizations | |
| // This for-loop is used to test V8 Fast API optimizations. |
|
@nodejs/build it seems windows-fanned build is failing. is there an outage? |
Qard
approved these changes
Jul 17, 2023
anonrig
added
the
commit-queue
26 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jul 18, 2023
PR-URL: #48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
Landed in e0500d6 |
Merged
|
@anonrig this will need a backport to v18.x-staging |
juanarbol
pushed a commit
that referenced
this pull request
Jul 18, 2023
PR-URL: #48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced Jul 19, 2023
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
PR-URL: nodejs#48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
PR-URL: nodejs#48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48817 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
panva
removed
the
commit-queue
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48816
I requested fast-track to include this change with the currently pending Node 18 release (which includes
URL.canParseas well. cc @danielleadamscc @nodejs/url