Skip to content

test: fix es-module/test-esm-initialization #48880

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2023
Merged

test: fix es-module/test-esm-initialization #48880

merged 1 commit into from
Jul 29, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 21, 2023

The --experimental-import-meta-resolve flag was not supplied, when the target file does use import.meta.resolve. I also cleaned up the comments.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 21, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52908/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52938/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2023
This was referenced Jul 27, 2023
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 42b5711 into nodejs:main Jul 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 42b5711

@aduh95 aduh95 deleted the esm-init-test branch July 29, 2023 10:57
This was referenced Jul 30, 2023
Open
Open
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@aduh95
test: fix es-module/test-esm-initialization
d840193 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@aduh95
test: fix es-module/test-esm-initialization
018b67b 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
test: fix es-module/test-esm-initialization
b2ce51d 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
test: fix es-module/test-esm-initialization
f32d1bb 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@aduh95 @UlisesGascon
test: fix es-module/test-esm-initialization
869adb4 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
test: fix es-module/test-esm-initialization
33fe631 
PR-URL: #48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@aduh95 @RafaelGSS
test: fix es-module/test-esm-initialization
314bd60 
PR-URL: #48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
test: fix es-module/test-esm-initialization
0a9e81e 
PR-URL: nodejs#48880
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
test: fix es-module/test-esm-initialization
f02637e 
PR-URL: #48880
Backport-PR-URL: #50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix es-module/test-esm-initialization
0e34686 
PR-URL: nodejs/node#48880
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: fix es-module/test-esm-initialization
8f3e568 
PR-URL: nodejs/node#48880
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @lpinca @targos