Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: set port in node_options to uint16_t #49151

Closed
wants to merge 2 commits into from
Closed

src: set port in node_options to uint16_t #49151

wants to merge 2 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 13, 2023

Resolves a TODO left by @joyeecheung

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 13, 2023
@anonrig anonrig force-pushed the set-port-as-uint16t branch 2 times, most recently from 0dd1eca to 3dafabd Compare August 13, 2023 20:09
@anonrig anonrig force-pushed the set-port-as-uint16t branch from 034d649 to 681c625 Compare August 14, 2023 15:50
@anonrig
Copy link
Member Author

anonrig commented Aug 14, 2023

@joyeecheung I've made some changes to the port parsing algorithm as well.

@anonrig anonrig force-pushed the set-port-as-uint16t branch from 681c625 to b25c5e9 Compare August 15, 2023 18:39
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53360/

This was referenced Aug 17, 2023
Open
Open
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53567/

This was referenced Aug 27, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53622/

This was referenced Aug 30, 2023
Open
Open
@anonrig anonrig mentioned this pull request Sep 25, 2023
Closed
@anonrig anonrig force-pushed the set-port-as-uint16t branch from b25c5e9 to f10e1aa Compare September 27, 2023 13:48
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54284/

@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54362/

@github-actions github-actions bot mentioned this pull request Sep 30, 2023
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54419/

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Open
16 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2023
anonrig added a commit that referenced this pull request Oct 4, 2023
@anonrig
src: set port in node_options to uint16_t
66776d8 
PR-URL: #49151
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@anonrig
Copy link
Member Author

anonrig commented Oct 4, 2023

Landed in 66776d8

@anonrig anonrig closed this Oct 4, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
src: set port in node_options to uint16_t
7682bec 
PR-URL: nodejs#49151
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
src: set port in node_options to uint16_t
e1df69e 
PR-URL: #49151
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@anonrig @debadree25
src: set port in node_options to uint16_t
ead31aa 
PR-URL: nodejs#49151
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @joyeecheung @panva @lpinca