Skip to content

src: fix fs_type_to_name default value #49239

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

src: fix fs_type_to_name default value #49239

merged 1 commit into from
Sep 7, 2023

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Aug 19, 2023 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 19, 2023
@0o001 0o001 changed the title src: fs_type_to_name default value src: fix fs_type_to_name default value Aug 20, 2023
@aduh95
Copy link
Contributor

aduh95 commented Aug 28, 2023

@nodejs/fs

LiviaMedeiros
LiviaMedeiros approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 28, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53591/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53595/

This was referenced Aug 29, 2023
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53764/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53774/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53790/

@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0bce573 into nodejs:main Sep 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0bce573

This was referenced Sep 8, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@0o001 @ruyadorno
src: fix fs_type_to_name default value
2d3f5c7 
PR-URL: #49239
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: theanarkh <theratliter@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@0o001 @alexfernandez
src: fix fs_type_to_name default value
61f6b5a 
PR-URL: nodejs#49239
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: theanarkh <theratliter@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@theanarkh theanarkh theanarkh approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0o001 @aduh95 @nodejs-github-bot @tniessen @theanarkh @LiviaMedeiros