build: add symlink to compile_commands.json file if needed
#49260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs-github-bot
added
build
|
cc @nodejs/build-files |
anonrig
approved these changes
Aug 22, 2023
27 tasks
github-actions
bot
removed
the
request-ci
27 tasks
juanarbol
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5ff1ead |
This was referenced Aug 25, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #49260 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs#49260 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #49260 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs/node#49260 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Usually lsp servers needs the `compile_commands.json` file in the root directory. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs/node#49260 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually lsp servers needs the
compile_commands.jsonfile in the root directory.