tls: remove redundant code in onConnectSecure() #49457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant code by moving it to outside of `if/else`.
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Sep 2, 2023
github-actions
bot
removed
the
request-ci
KhafraDev
approved these changes
Sep 2, 2023
debadree25
added
the
author ready
UlisesGascon
approved these changes
Sep 2, 2023
deokjinkim
added
the
commit-queue
This was referenced Sep 3, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in c8628ed |
This was referenced Sep 5, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Remove redundant code by moving it to outside of `if/else`. PR-URL: #49457 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Remove redundant code by moving it to outside of `if/else`. PR-URL: nodejs#49457 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant code by moving it to outside of
if/else.Below code is duplicated because it exists on both if and else.