Skip to content

[v18.x backport] Backport a couple of PRs #49618

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v18.x backport] Backport a couple of PRs #49618

wants to merge 2 commits into from

Conversation

atlowChemi
Copy link
Member

Backports #47775 and #48521 (which was blocked by #47775)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 12, 2023
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53907/

@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Open
14 tasks
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Open
15 tasks
@atlowChemi atlowChemi force-pushed the backport-47775-and-48521-to-18 branch from 9cde48f to bdd8165 Compare September 14, 2023 05:40
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53948/

This was referenced Sep 15, 2023
Open
Open
@ErickWendel ErickWendel mentioned this pull request Sep 16, 2023
Closed
@github-actions github-actions bot mentioned this pull request Sep 17, 2023
Open
32 tasks
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Open
33 tasks
ErickWendel and others added 2 commits September 18, 2023 08:34
@ErickWendel @atlowChemi
test_runner: add initial draft for fakeTimers
5e66fec 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs#47775
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@atlowChemi
fs: use kResistStopPropagation
e2e8ce6 
PR-URL: nodejs#48521
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@atlowChemi atlowChemi force-pushed the backport-47775-and-48521-to-18 branch from bdd8165 to e2e8ce6 Compare September 18, 2023 05:46
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54024/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 18, 2023 •
edited by ruyadorno
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/54027/
CITGM (v18.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3298/
CITGM: https://ci.nodejs.org/job/citgm-smoker/3300/

This was referenced Sep 19, 2023
Open
Open
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Open
22 tasks
@ruyadorno
Copy link
Member

Hi @atlowChemi I did a citgm run for this PR and there are a few issues popping up:

ncu-ci citgm 3298 3300
--------------------------------------------------------------------------------
[1/1] Running CITGM: 3298
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3298/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v18.x
Commit     [779043d5297f] Working on v18.18.1
Date       2023-09-18 17:21:18 -0400
Author     Ruy Adorno <ruyadorno@google.com>
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3300/
Source     https://github.com/nodejs/node/pull/49618/
Commit     [e2e8ce639ca1] fs: use kResistStopPropagation
Date       2023-09-18 08:34:30 +0300
Author     Chemi Atlow <chemi@atlow.co.il>
----------------------------------- Results ------------------------------------



FAILURE: 8 failures in 3300 not present in 3298


┌───────────────┬─────────────────────────┬─────────────────────────┐
│    (index)    │            0            │            1            │
├───────────────┼─────────────────────────┼─────────────────────────┤
│  win-vs2019   │     'pino-v8.15.4'      │                         │
│ ubuntu1804-64 │ 'torrent-stream-v1.2.1' │                         │
│   rhel8-x64   │  'multer-v1.4.5-lts.1'  │ 'torrent-stream-v1.2.1' │
│  rhel8-s390x  │ 'torrent-stream-v1.2.1' │                         │
│  aix72-ppc64  │ 'torrent-stream-v1.2.1' │                         │
│ rhel8-ppc64le │     'pino-v8.15.4'      │ 'torrent-stream-v1.2.1' │
│    osx1015    │                         │                         │
└───────────────┴─────────────────────────┴─────────────────────────┘

While it does seem like it may be a timeout problem that might be caused by the library / tests errors, I would appreciate if you can take some time to look at the results for torrent-stream@1.2.1 on https://ci.nodejs.org/job/citgm-smoker/3300/

pino@8.15.x and multer@1.4.5 issues are already documented so you don't need to worry about these.

@atlowChemi
Copy link
Member Author

@ruyadorno I do not think this is related (though I do not have any cutting proof 😕)
Going through the logs & codebase I couldn't find any connection between the failures and the changes in this PR

@targos
Copy link
Member

targos commented Oct 28, 2023 •
edited
Loading

Landed in 05e7f28 and fe41d22

@targos targos closed this Oct 28, 2023
targos pushed a commit that referenced this pull request Oct 28, 2023
@ErickWendel @targos
test_runner: add initial draft for fakeTimers
f0536f8 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: #47775
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
@atlowChemi @targos
fs: use kResistStopPropagation
29dc4b6 
PR-URL: #48521
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
@ErickWendel @targos
test_runner: add initial draft for fakeTimers
05e7f28 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: #47775
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
@atlowChemi @targos
fs: use kResistStopPropagation
fe41d22 
PR-URL: #48521
Backport-PR-URL: #49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add initial draft for fakeTimers
6404794 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs/node#47775
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: use kResistStopPropagation
04cf386 
PR-URL: nodejs/node#48521
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add initial draft for fakeTimers
692d6c3 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs/node#47775
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
fs: use kResistStopPropagation
9d508d9 
PR-URL: nodejs/node#48521
Backport-PR-URL: nodejs/node#49618
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ruyadorno ruyadorno Awaiting requested review from ruyadorno

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atlowChemi @nodejs-github-bot @ruyadorno @targos @ErickWendel