Skip to content

[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages #49620

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages #49620

wants to merge 1 commit into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Sep 12, 2023 •
edited
Loading

also added more webstream creation benchmarks

PR-URL: #49546
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels Sep 12, 2023
@rluvaton rluvaton changed the title stream: improve tee perf by reduce ReflectConstruct usages [v20.x backport] stream: improve tee perf by reduce ReflectConstruct usages Sep 12, 2023
@rluvaton rluvaton mentioned this pull request Sep 12, 2023
Merged
@rluvaton
stream: improve tee perf by reduce ReflectConstruct usages
3f7b05e 
also added more webstream creation benchmarks

PR-URL: nodejs#49546
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@rluvaton rluvaton force-pushed the backport-49546-to-v20.x branch from 8eb0194 to 3f7b05e Compare September 12, 2023 13:41
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53912/

@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Open
14 tasks
mcollina
mcollina approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

UlisesGascon pushed a commit that referenced this pull request Sep 13, 2023
@rluvaton @UlisesGascon
stream: improve tee perf by reduce ReflectConstruct usages
8aac95d 
also added more webstream creation benchmarks

PR-URL: #49546
Backport-PR-URL: #49620
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGascon
Copy link
Member

Landed in 8aac95d

This was referenced Sep 14, 2023
Open
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluvaton @nodejs-github-bot @UlisesGascon @mcollina @benjamingr